This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Updating to latest dojo/shim #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
approved these changes
Jul 26, 2017
|
ci failures are unrelated. tests in master are failing right now due to update in globalize/cldr |
|
@rorticus should we pin the dependency? |
|
@mwistrand do you have thoughts on this? |
|
I would be okay with pinning the version and manually updating as changes are verified to not break anything. In this case, the tests are failing because timezone offsets are now separated with U+2212 (minus sign). I've been trying to get a fix in but am currently fighting issues with npm/node. |
mwistrand
approved these changes
Jul 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updating to use latest shim, dojo/shim#101.