Skip to content
This repository was archived by the owner on Jul 30, 2018. It is now read-only.

Updating to use loader from grunt-dojo2 #59

Closed
wants to merge 1 commit into from

Conversation

rorticus
Copy link
Contributor

@rorticus rorticus commented Nov 6, 2017

Updating to use helpers from dojo/shim#114 and loader from grunt-dojo2

@rorticus rorticus requested a review from kitsonk November 6, 2017 19:48
@rorticus rorticus mentioned this pull request Nov 10, 2017
3 tasks
@bryanforbes
Copy link
Member

I don't think downlevelIteration needs to be turned on or the loader configuration removed for has:

  • has doesn't need a shim (it takes in promise-like objects, but doesn't create them).
  • Downlevel iteration will create a hard dependency on @dojo/shim or put helpers into the global space and the only thing that uses it is some unit tests.
  • Removing the loader configuration means we rely on grunt-dojo2's loader which requires @dojo/shim which creates a dev dependency on @dojo/shim (which is circular)
  • The only helper that has uses is __exportStar. It doesn't matter if it's using tslib or the patched one from @dojo/shim.

@rorticus
Copy link
Contributor Author

This doesn't make sense for dojo/has, so closing.

@rorticus rorticus closed this Nov 14, 2017
@dylans dylans added this to the 2017.11 milestone Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants