Ensure that nodes are inserted in the correct position when nested within widgets #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
approved these changes
Mar 19, 2019
agubler
added
the
needs back-port
agubler
added a commit
to agubler/framework
that referenced
this pull request
Mar 28, 2019
…thin widgets (dojo#297) * Failing unit test for incorrect node insertion with nested widgets * Ensure the domNode is set up the tree on all immediate parent WNodeWrappers * simplify test * Improve failing unit test scenario * Only copy over domNode on widget update if there is a parent node
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
In scenarios where there are multiple nested widgets, the child
domNodeis not applied to the top level widget. This means that when there are two siblings that have nested widgets looking up thedomNodefor the insert before position does not work.Additionally, when copying over the associated
domNodeto the new WNodeWrapper, check that it is still attached to the DOM when updating a widget, if the previousdomNodeis not attached to the DOM then do not copy over and let the attachment process execute to add the newdomNode.Resolves #296