Use root node display property to set custom element root node display property #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
Use the root node of the widgets display property and set it on the custom element node. If none set default to
block
which is more common/preferable than the custom element default ofinline
This solution differs to what I originally postured here: #209 (comment), because I think this way is simpler, slightly more ergonomic and a lot of
dojo/widgets
already specify the desireddisplay
on their root node (for example: https://github.com/dojo/widgets/blob/master/src/theme/button.m.css#L5)Resolves #209
Thanks to @jcfranco for raising the original issue.