Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use root node display property to set custom element root node display property #216

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

matt-gadd
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

Description:
Use the root node of the widgets display property and set it on the custom element node. If none set default to block which is more common/preferable than the custom element default of inline

This solution differs to what I originally postured here: #209 (comment), because I think this way is simpler, slightly more ergonomic and a lot of dojo/widgets already specify the desired display on their root node (for example: https://github.com/dojo/widgets/blob/master/src/theme/button.m.css#L5)

Resolves #209

Thanks to @jcfranco for raising the original issue.

@matt-gadd matt-gadd merged commit 9a3e69f into dojo:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants