Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty column labels #664

Closed
wants to merge 1 commit into from
Closed

Allow empty column labels #664

wants to merge 1 commit into from

Conversation

gratex
Copy link

@gratex gratex commented Jul 19, 2013

No description provided.

@ghost ghost closed this in 51d5f4f Jul 19, 2013
@kfranqueiro
Copy link
Member

This was a good idea, but rather than require people to specify blank labels as null, which feels unnatural, I've fixed the code in Grid, GridFromHtml, and selector to allow specifying an actual empty string for a blank label.

@gratex
Copy link
Author

gratex commented Jul 22, 2013

My solution was also accepting empty strings for empty labels (and NULL for using column.field as fallback - same as in previous implementation).
Now if you specify NULL as label, you will have "null" string in the header.

But thank you anyway, usage with empty string is working.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants