Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes aspect related memory leaks #1418

Merged
merged 1 commit into from
Apr 10, 2018
Merged

fixes aspect related memory leaks #1418

merged 1 commit into from
Apr 10, 2018

Conversation

buggedcom
Copy link
Contributor

This is related to #1414, however there are many untracked aspect events.

dylans
dylans approved these changes Apr 10, 2018
View reviewed changes
Copy link
Member

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, theses changes look reasonable to me.

@buggedcom
Copy link
Contributor Author

Additionally, I'm doing a deep dive into memory leaks in our product and there are a few more inside dgrid, so over the next few days/weeks I'll be sending some more PRs this way.

@edhager
Copy link
Contributor

edhager commented Apr 10, 2018

Code changes look good. Unit tests pass. 👍

@dylans dylans merged commit 8af200e into dojo:master Apr 10, 2018
@dylans dylans added this to the 1.2.2 milestone Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylans dylans dylans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@buggedcom @edhager @dylans