Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noDataMessage displayed twice on page refresh #542

Closed
khoying opened this issue Apr 15, 2013 · 2 comments
Closed

noDataMessage displayed twice on page refresh #542

khoying opened this issue Apr 15, 2013 · 2 comments

Comments

@khoying
Copy link

khoying commented Apr 15, 2013

I am able to get the noDataMessage to display twice be refreshing my page. I looked and the code does not check to clear the node before adding the noDataMessage. It seems like it should to ensure that it does not get created more than once.

@kfranqueiro
Copy link
Member

Can you provide a bit of detail about your use case, especially whether your store is synchronous or asynchronous? Currently I seem to be able to reproduce this only specifically in the case of quickly refreshing an empty asynchronous store, but it does happen both with OnDemandList and Pagination.

@khoying
Copy link
Author

khoying commented Apr 19, 2013

Thank you for the follow up.

I am using the OnDemandGrid with the dojo/store/JsonRest store. I did look at the source code and notice that it seems to always just add the message. It seems like a simple fix would be to just check to see if it is already there and if so not add it twice or remove it and then add it.

Please let me know if you need anything else.

Thanks,
Ken

From: Kenneth G. Franqueiro [mailto:notifications@github.com]
Sent: Friday, April 19, 2013 9:37 AM
To: SitePen/dgrid
Cc: Hoying, Ken
Subject: Re: [dgrid] noDataMessage displayed twice on page refresh (#542)

Can you provide a bit of detail about your use case, especially whether your store is synchronous or asynchronous? Currently I seem to be able to reproduce this only specifically in the case of quickly refreshing an empty asynchronous store, but it does happen both with OnDemandList and Pagination.


Reply to this email directly or view it on GitHubhttps://github.com//issues/542#issuecomment-16653257.


***Note:The information contained in this message may be privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, or an employee or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the Sender immediately by replying to the message and deleting it from your computer. Thank you. Premier Inc.

@msssk msssk closed this as completed in f830660 Jun 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants