Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'set' function in subRow definition can be ignored #489

Closed
nikkikom opened this issue Mar 13, 2013 · 1 comment
Closed

'set' function in subRow definition can be ignored #489

nikkikom opened this issue Mar 13, 2013 · 1 comment

Comments

@nikkikom
Copy link

If the grid uses subrows, the 'set' functions is ignored for all subrows but the last one.

The DGrid calls _configColumns() for each subrow. The _StoreMixin clears this._columnsWithSet in its _configColumns(). Thus only the last subrow's 'set' functions finally stored in this._columnsWithSet.
brandonpayton added a commit to brandonpayton/dgrid that referenced this issue Mar 26, 2013
@brandonpayton
Fix for GH dgrid issue dojo#489.
0bf4948 
Updated _StoreMixin to reset _columnsWithSet only when configStructure() is called,
rather than resetting it everytime _configColumns() is called because
_configColumns() is called multiple times for column configurations
containing subRows.
@kfranqueiro
Copy link
Member

This was fixed back in late March 2013 primarily via 0bf4948. I didn't notice at the time that this ticket was accidentaly left open. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfranqueiro @nikkikom