OnDemandGrid does not load additional rows when grid height gets bigger and therefore more rows could be displayed

[frabe]

Open test

dgrid/test/OnDemand_promises.html

Make height of grid bigger by executing

require(["dojo/dom-style"], function(domStyle){ 
  domStyle.set("grid", "height", "1000px");
});

Grid still displayes only 25 rows even if there is space for more.

[ttrenka]

Set minRowsPerPage and/or maxRowsPerPage before adjusting the height of the dgrid.

[frabe]

Thanks for your answer Tom!

like this:

require(["dojo/dom-style"], function(domStyle){ 
  myGridInstance.set("minRowsPerPage", 30);
  domStyle.set("grid", "height", "1000px");
});

I see no difference

[ttrenka]

I'm not sure if .set will work, since I am using an older pre-beta version of dgrid. But I'd suggest cranking that number up and seeing if that helps at all. I know I'm able to do this directly with the older version of dgrid (and in fact wrote a custom extension to expand or contract the height of a dgrid on the fly)...

[ghost]

Whoops. Didn't mean for that to close this, I guess github saw "resolves blah" and didn't care about the "partially".

This is a legit issue; however, keep in mind that any time you directly change the dimensions of the grid, you're going to have to call resize on it to get it to react; otherwise it has no way of knowing.

This fixes the issue in most cases, by calling _processScroll from resize. However, there's still a problematic edge case (literally actually, I see it happen when the grid is scrolled all the way up), where for some reason _processScroll isn't even checking the lower preload node, so it's not properly requesting more data. I'll have to look into that at a later point in time.