This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Move createHandle’s destroy from context to a flag #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanforbes
reviewed
Apr 27, 2018
src/lang.ts
Outdated
| @@ -364,10 +364,13 @@ export function partial(targetFunction: (...args: any[]) => any, ...suppliedArgs | |||
| * @return The handle object | |||
| */ | |||
| export function createHandle(destructor: () => void): Handle { | |||
| var called = false; | |||
There was a problem hiding this comment.
Ugh, I've been working with dojo 1
There was a problem hiding this comment.
I even had the red squiggly
bryanforbes
approved these changes
Apr 27, 2018
dylans
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
If the destroy function in the response object from
createHandlewas called in a different context than the original,destroywould be assigned to the call object and thedestructorfunction would also be called in that context. By using a flag, we can guarantee the destructor is only called once regardless of associated context.