-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
CI failures due to unreleased dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of thoughts...
src/List.ts
Outdated
@@ -1,4 +1,4 @@ | |||
import { forOf, Iterable, IterableIterator, ShimIterator } from '@dojo/shim/iterator'; | |||
import {Iterable, IterableIterator, ShimIterator} from '@dojo/shim/iterator'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit... spaces between the braces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh WebStorm. I had to reinstall it and it looks like my special dojo2 style settings got disappeared. I'll have to go through the style guide and create a new one 😕
src/MultiMap.ts
Outdated
@@ -1,7 +1,7 @@ | |||
import '@dojo/shim/Symbol'; | |||
import Map from '@dojo/shim/Map'; | |||
import { from as arrayFrom } from '@dojo/shim/array'; | |||
import { forOf, Iterable, IterableIterator, ShimIterator } from '@dojo/shim/iterator'; | |||
import {from as arrayFrom} from '@dojo/shim/array'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spaces between braces, spaces between braces, spaces between braces (see it rhymes)
@@ -1,4 +1,4 @@ | |||
import { Iterable, forOf, isIterable, isArrayLike } from '@dojo/shim/iterator'; | |||
import { Iterable, isIterable, isArrayLike } from '@dojo/shim/iterator'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You see, you can do it! :-D
src/load/util.ts
Outdated
@@ -1,5 +1,5 @@ | |||
import { forOf, isIterable, isArrayLike } from '@dojo/shim/iterator'; | |||
import { Load } from '../load'; | |||
import {isArrayLike, isIterable} from '@dojo/shim/iterator'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭
src/request/Headers.ts
Outdated
@@ -1,5 +1,5 @@ | |||
import { Headers as HeadersInterface } from './interfaces'; | |||
import { IterableIterator, forOf, ShimIterator } from '@dojo/shim/iterator'; | |||
import {Headers as HeadersInterface} from './interfaces'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
src/request/providers/xhr.ts
Outdated
@@ -1,15 +1,14 @@ | |||
import { Handle } from '@dojo/interfaces/core'; | |||
import {Handle} from '@dojo/interfaces/core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editors gone wild... next on the Discovery Channel
bb295eb
to
3f7ddd5
Compare
Upgrade to use latest from shim, dojo/shim#114 .
for..of