This repository was archived by the owner on Jul 30, 2018. It is now read-only.
Shim helpers #365
Merged
Shim helpers #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures due to unreleased dependencies |
kitsonk
reviewed
Nov 7, 2017
src/List.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| import { forOf, Iterable, IterableIterator, ShimIterator } from '@dojo/shim/iterator'; | |||
| import {Iterable, IterableIterator, ShimIterator} from '@dojo/shim/iterator'; | |||
There was a problem hiding this comment.
minor nit... spaces between the braces
There was a problem hiding this comment.
Ugh WebStorm. I had to reinstall it and it looks like my special dojo2 style settings got disappeared. I'll have to go through the style guide and create a new one 😕
src/MultiMap.ts
Outdated
| @@ -1,7 +1,7 @@ | |||
| import '@dojo/shim/Symbol'; | |||
| import Map from '@dojo/shim/Map'; | |||
| import { from as arrayFrom } from '@dojo/shim/array'; | |||
| import { forOf, Iterable, IterableIterator, ShimIterator } from '@dojo/shim/iterator'; | |||
| import {from as arrayFrom} from '@dojo/shim/array'; | |||
There was a problem hiding this comment.
spaces between braces, spaces between braces, spaces between braces (see it rhymes)
| @@ -1,4 +1,4 @@ | |||
| import { Iterable, forOf, isIterable, isArrayLike } from '@dojo/shim/iterator'; | |||
| import { Iterable, isIterable, isArrayLike } from '@dojo/shim/iterator'; | |||
src/load/util.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import { forOf, isIterable, isArrayLike } from '@dojo/shim/iterator'; | |||
| import { Load } from '../load'; | |||
| import {isArrayLike, isIterable} from '@dojo/shim/iterator'; | |||
src/request/Headers.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import { Headers as HeadersInterface } from './interfaces'; | |||
| import { IterableIterator, forOf, ShimIterator } from '@dojo/shim/iterator'; | |||
| import {Headers as HeadersInterface} from './interfaces'; | |||
src/request/providers/xhr.ts
Outdated
| @@ -1,15 +1,14 @@ | |||
| import { Handle } from '@dojo/interfaces/core'; | |||
| import {Handle} from '@dojo/interfaces/core'; | |||
There was a problem hiding this comment.
editors gone wild... next on the Discovery Channel
This was referenced Nov 7, 2017
rorticus
force-pushed
the
shim-helpers
branch
from
bb295eb to
3f7ddd5
Compare
kitsonk
approved these changes
Nov 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to use latest from shim, dojo/shim#114 .
for..of