Skip to content
This repository was archived by the owner on Jul 30, 2018. It is now read-only.

Shim helpers #365

Merged
merged 9 commits into from
Nov 13, 2017
Merged

Shim helpers #365

merged 9 commits into from
Nov 13, 2017

Conversation

rorticus
Copy link
Contributor

@rorticus rorticus commented Nov 6, 2017

Upgrade to use latest from shim, dojo/shim#114 .

  • Conversion to use for..of
  • Using shimAmdDependencies and new intern loader (from grunt-dojo2)

@rorticus rorticus requested a review from kitsonk November 6, 2017 15:44
@rorticus
Copy link
Contributor Author

rorticus commented Nov 6, 2017

CI failures due to unreleased dependencies

Copy link
Member

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of thoughts...

src/List.ts Outdated
@@ -1,4 +1,4 @@
import { forOf, Iterable, IterableIterator, ShimIterator } from '@dojo/shim/iterator';
import {Iterable, IterableIterator, ShimIterator} from '@dojo/shim/iterator';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit... spaces between the braces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh WebStorm. I had to reinstall it and it looks like my special dojo2 style settings got disappeared. I'll have to go through the style guide and create a new one 😕

src/MultiMap.ts Outdated
@@ -1,7 +1,7 @@
import '@dojo/shim/Symbol';
import Map from '@dojo/shim/Map';
import { from as arrayFrom } from '@dojo/shim/array';
import { forOf, Iterable, IterableIterator, ShimIterator } from '@dojo/shim/iterator';
import {from as arrayFrom} from '@dojo/shim/array';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces between braces, spaces between braces, spaces between braces (see it rhymes)

@@ -1,4 +1,4 @@
import { Iterable, forOf, isIterable, isArrayLike } from '@dojo/shim/iterator';
import { Iterable, isIterable, isArrayLike } from '@dojo/shim/iterator';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You see, you can do it! :-D

src/load/util.ts Outdated
@@ -1,5 +1,5 @@
import { forOf, isIterable, isArrayLike } from '@dojo/shim/iterator';
import { Load } from '../load';
import {isArrayLike, isIterable} from '@dojo/shim/iterator';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@@ -1,5 +1,5 @@
import { Headers as HeadersInterface } from './interfaces';
import { IterableIterator, forOf, ShimIterator } from '@dojo/shim/iterator';
import {Headers as HeadersInterface} from './interfaces';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@@ -1,15 +1,14 @@
import { Handle } from '@dojo/interfaces/core';
import {Handle} from '@dojo/interfaces/core';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editors gone wild... next on the Discovery Channel

@rorticus rorticus merged commit 1e7b0a8 into dojo:master Nov 13, 2017
@dylans dylans added this to the beta.4 milestone Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants