Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Fix "random" XHR test fail. #361

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Conversation

edhager
Copy link
Contributor

@edhager edhager commented Oct 31, 2017

A security error occurs in IE11 on Windows 8.1 (and probably older) in the web-worker-xhr-upload has test causing the has test to be removed from the cache. This fix makes the has test return false when the security error occurs.

This test failure appeared to be random because we were asking for IE11 on "WINDOWS" in the intern configuration. I added more specific operating system requests to intern.json.

Searching in Google revealed that the security error was occurring in Windows 10 but a fix in Windows 10 was released.

Fixes #358

…s 8.1 (and probably older) in the web-worker-xhr-upload has test causing the has test to be removed from the cache. This fix makes the has test return false when the security error occurs.
@edhager
Copy link
Contributor Author

edhager commented Oct 31, 2017

The "utility functions - throttle - throttles callback" test will fail. That is fixed in another PR.

Copy link
Contributor

@rorticus rorticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! That must have been fun to track down 😄

@edhager edhager merged commit 1dd6ce3 into dojo:master Nov 1, 2017
@edhager edhager deleted the xhr-test-fail-358 branch November 1, 2017 17:01
@dylans dylans added this to the beta.4 milestone Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xhr unit tests intermittently fail on IE11
4 participants