This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Changes to align with shim refactors #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
reviewed
Jul 11, 2017
src/aspect.ts
Outdated
| @@ -281,7 +281,7 @@ function getDispatcherObject(target: Targetable, methodName: string): Dispatcher | |||
| function getJoinPointDispatcher<F extends GenericFunction<T>, T>(joinPoint: F): F { | |||
|
|
|||
| function dispatcher(this: Function, ...args: any[]): T { | |||
| const { before, after, joinPoint } = dispatchAdviceMap.get(dispatcher); | |||
| const { before, after, joinPoint } = dispatchAdviceMap.get(dispatcher)!; | |||
There was a problem hiding this comment.
I don't think we should be ignoring the strict null checks, I believe you mentioned that it can now correctly return undefined so we should probably guard against that appropriately.
There was a problem hiding this comment.
I was debating this, since from the code below, you could never get a situation where the map for the dispatcher is undefined, because the only way the way the function could be called is if its map had been set.
There was a problem hiding this comment.
I have added comments to document the use of not null assertion is appropriate because we can't logically have undefined values from the maps.
rorticus
approved these changes
Jul 26, 2017
agubler
approved these changes
Jul 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
These PRs are updates to keep in sync with changes in PR dojo/shim#101