Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim helpers #175

Merged
merged 3 commits into from
Nov 15, 2017
Merged

Shim helpers #175

merged 3 commits into from
Nov 15, 2017

Conversation

rorticus
Copy link
Contributor

Using tslib from @dojo/shim and enabling downlevel iteration.

@rorticus rorticus requested a review from kitsonk November 10, 2017 14:18
@rorticus rorticus mentioned this pull request Nov 10, 2017
3 tasks
@codecov
Copy link

codecov bot commented Nov 10, 2017

Codecov Report

Merging #175 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   97.88%   97.89%   +<.01%     
==========================================
  Files          16       16              
  Lines         379      380       +1     
  Branches       49       49              
==========================================
+ Hits          371      372       +1     
  Misses          4        4              
  Partials        4        4
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca9789...ab69638. Read the comment docs.

Copy link
Member

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target is es2016... downlevelIteration is meaningless here...

@rorticus rorticus merged commit 9ad411e into dojo:master Nov 15, 2017
@dylans dylans added this to the beta.4 milestone Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants