Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promise shim to entry #263

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Apr 9, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Include the @dojo/framework/shim/Promise module in the main entry point, this is to ensure that the bootstrap plugin works for IE11.

Related to dojo/webpack-contrib#140

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #263 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   51.88%   51.88%           
=======================================
  Files          10       10           
  Lines         638      638           
  Branches      162      162           
=======================================
  Hits          331      331           
  Misses        307      307
Impacted Files Coverage Δ
src/base.config.ts 23.15% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1995cac...cf700a7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants