Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evergreen builds do not transform CSS variables #151

Closed
wants to merge 2 commits into from

Conversation

rorticus
Copy link
Contributor

Update to disable css custom properties when not doing a legacy build.

Before:

--my-color: blue;

.myClass {
    color: blue;
    color: var(--my-color);
}

Now,

--my-color: blue;

.myClass {
    color: var(--my-color);
}

@rorticus rorticus requested review from agubler and matt-gadd August 29, 2018 13:10
@codecov
Copy link

codecov bot commented Aug 29, 2018

Codecov Report

Merging #151 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage      56%   55.88%   -0.12%     
==========================================
  Files           8        8              
  Lines         475      476       +1     
  Branches      113      114       +1     
==========================================
  Hits          266      266              
- Misses        209      210       +1
Impacted Files Coverage Δ
src/base.config.ts 27.96% <0%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6b785...ad7ebc7. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #151 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   54.77%   54.67%   -0.11%     
==========================================
  Files          10       10              
  Lines         544      545       +1     
  Branches      125      126       +1     
==========================================
  Hits          298      298              
- Misses        246      247       +1
Impacted Files Coverage Δ
src/base.config.ts 25.37% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce07784...d0b9208. Read the comment docs.

@agubler
Copy link
Member

agubler commented Oct 27, 2018

For the time being we support css vars so for browsers that support it we have the story covered. Long term we should look at this again and stop bullet proofing the vars, but for now closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants