[d3d9] Adjust SM2 VS/PS caps #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterSnowfall
force-pushed
the
d3d9-sm2caps
branch
from
627c7c6 to
9f38229
Compare
|
Has this been compared against native, or do the actuial values not change and we just report 0 if we disable sm2 support? |
For now I've only compared it with WineD3D, which seems to follow the constants, so I don't have much concerns there. And for SM1, I checked on Windows XP / a GeForce 4 Ti and they are all 0. P.S.: The constants are identical in value to what @misyltoad had set initially, btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were ultimately (largely) correct, but they do have D3D constants defined.
I still have to check how all of these show up on a SM1 capable card, so WIP for now.Update: I've checked, and they're all 0 for SM1 (and fixed-function ofc).Doubt it matters much beyond esthetics, but let's unleash it in experimental for a while.