Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Return Revet result as Data #354

Conversation

0xcb9ff9
Copy link

@0xcb9ff9 0xcb9ff9 commented Jun 17, 2023

Description

upstream PR: #1566

This allows returning custom revert errors from solidity, they are ABI encoded functions that can represent rich and gas efficient revert messages.

Details of custom errors: https://blog.soliditylang.org/2021/04/21/custom-errors/

This is the implementation expected by ethers.js and web3.js and the format go-ethereum chose ethereum/go-ethereum#19027 (comment)

Changes include

  • New feature (non-breaking change that adds functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels

Testing

  • I have tested this code with the official test suite

@0xcb9ff9 0xcb9ff9 added the feature New update to Dogechain label Jun 17, 2023
@0xcb9ff9 0xcb9ff9 self-assigned this Jun 17, 2023
@0xcb9ff9 0xcb9ff9 changed the title [] Return Revet result as Data [feature] Return Revet result as Data Jun 17, 2023
@0xcb9ff9 0xcb9ff9 changed the title [feature] Return Revet result as Data [Feature] Return Revet result as Data Jun 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #354 (c72d160) into dev (c202b4e) will decrease coverage by 0.02%.
The diff coverage is 72.72%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #354      +/-   ##
==========================================
- Coverage   47.66%   47.64%   -0.02%     
==========================================
  Files         136      136              
  Lines       20603    20625      +22     
==========================================
+ Hits         9820     9827       +7     
- Misses       9954     9965      +11     
- Partials      829      833       +4     
Impacted Files Coverage Δ
jsonrpc/dispatcher.go 57.52% <53.84%> (-0.74%) ⬇️
jsonrpc/codec.go 70.27% <84.21%> (+1.84%) ⬆️
jsonrpc/eth_endpoint.go 71.40% <100.00%> (+0.44%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will save tremendous time for all DAPP developers.

@DarianShawn DarianShawn merged commit 00cac94 into dogechain-lab:dev Jun 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2023
@0xcb9ff9 0xcb9ff9 deleted the upstream/EVM-602-custom-solidity-errors-introduced-in-0-8-4-not-supported branch June 17, 2023 06:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Dogechain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants