Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix devtools install error #14

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

0xcb9ff9
Copy link

@0xcb9ff9 0xcb9ff9 commented Apr 20, 2023

Description

upstream PR: #1403

fix dev tools build error. Ref bnb-chain#1402

May change go-bindata to go embed later;
Changes

Notable changes:

  • Fixed the package path of go-bindata;

Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xcb9ff9 0xcb9ff9 self-assigned this Apr 20, 2023
@0xcb9ff9 0xcb9ff9 force-pushed the upstream/fix-install-dev-tools branch from b373278 to 8beec0c Compare April 20, 2023 06:58
@0xcb9ff9 0xcb9ff9 merged commit e9d9a8c into dev Apr 20, 2023
@0xcb9ff9 0xcb9ff9 deleted the upstream/fix-install-dev-tools branch April 20, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants