Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Windows users #10

Closed
GuillaumeBiessy opened this issue Mar 27, 2021 · 3 comments
Closed

Support for Windows users #10

GuillaumeBiessy opened this issue Mar 27, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@GuillaumeBiessy
Copy link

GuillaumeBiessy commented Mar 27, 2021

I really like the idea of hosting recipe on a website by using Markdown, keep up the good work !

I tried to follow the instructions and managed to found how to run bash on Windows through an Ubuntu distribution, however almost every line of code in build.sh throws an error, even the empty lines (because of the different line breaks I guess ?). I apologize if this sounds silly but I have very little experience on this topic.

Is this code intended to be used on a Windows machine ? Could you add instructions for Windows users ?

Thank you !

@doersino
Copy link
Owner

Hiya, thanks for checking this thing out! As mentioned in the readme, I haven't used Windows in a decade, so I don't have any experience with running bash scripts on Windows. (As a result, this code isn't really intended to be used on a Windows machine, but surely it's possible.)

It sounds like you've successfully set up WSL, so that seems like most of the work already done! Since you already suspect that line endings are to blame, it possible that you're running into this issue where Git automatically converts Linux/macOS-style line breaks into Windows-style line breaks, which causes Bash to throw up? It sounds like you might need to run git config --global core.autocrlf input, then make a fresh clone of the repository and try running the script.

If that works for you, I'll link to this issue from the readme.

@GuillaumeBiessy
Copy link
Author

GuillaumeBiessy commented Mar 27, 2021

Thank you for your quick reply.

I used the download ZIP approach rather than git clone and RStudio as my editor.
The issue with line breaks was not initially there but occurred when I tried modifying and saving the file.

Thanks for your answer, I was able to understand and fix the issue by going into the Rstudio Global Options => Code => Saving and setting Line ending conversion to LF.

I also got a second issue because I installed pandoc on Windows and not the virtual machine (I know I know but I'm not used to those things).
Now the bash build.sh command works for me and I was able to general the demo website, thank you !

@doersino
Copy link
Owner

I fondly remember those kinds of issues from my Windows days. 😉

I'm glad things are working now – happy cooking! I'll go and improve the setup instructions in the readme.

@doersino doersino added the documentation Improvements or additions to documentation label Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants