Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: tests on multiple node versions #983

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Chore: tests on multiple node versions #983

merged 1 commit into from
Jan 15, 2018

Conversation

anthony-redFox
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.098% when pulling 415eee1 on anthony-redFox:master into 4bb2047 on documentationjs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.098% when pulling 415eee1 on anthony-redFox:master into 4bb2047 on documentationjs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.098% when pulling 415eee1 on anthony-redFox:master into 4bb2047 on documentationjs:master.

@anthony-redFox
Copy link
Member Author

anthony-redFox commented Dec 27, 2017 •
edited
Loading

@tmcw I didn't add node version 4, I think we need to drop it.

Jest already drop support in 22.0 version
Node version 4 end life - April 2018 end life

@tmcw
Copy link
Member

tmcw commented Dec 29, 2017

Definitely, we should drop Node v4. Thanks for working on this, I'm pleasantly surprised that the tests pass on multiple versions!

@tmcw tmcw merged commit 27f75a9 into documentationjs:master Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmcw tmcw tmcw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthony-redFox @coveralls @tmcw