Close gap with flow #520
Merged
Close gap with flow #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds test support for flow difference * New support for FunctionTypeAnnotation * New support for ObjectTypeAnnotation * New support for MixedTypeAnnotation
|
|
||
| test('flowDoctrine', function (t) { | ||
|
|
||
| var types = FLOW_TYPES.filter(function (type) { | ||
| return type.match(/\wTypeAnnotation$/); |
There was a problem hiding this comment.
return /\wTypeAnnotation$/).test(type);would be cleaner here since all we want is a boolean.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns #512 into code; our test suite will judge whether we have complete flow support. cc @arv who has been doing lots of 💯 work with flow annotations.
In this branch:
any- this isn't exactly the Flow usage, but we also don't have a JSDoc annotation equivalent