Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node v5.0 support #253

Closed
3 tasks done
jfirebaugh opened this issue Nov 22, 2015 · 4 comments
Closed
3 tasks done

Node v5.0 support #253

jfirebaugh opened this issue Nov 22, 2015 · 4 comments

Comments

@jfirebaugh
Copy link
Member

@jfirebaugh
Copy link
Member Author

Most of the test failures happen on node 4.x as well. Looks like the behavior of localeCompare changed from 0.10/0.12 with respect to case sensitivity.

@tmcw
Copy link
Member

tmcw commented Nov 29, 2015

Upstream PR to mock-fs tschaub/mock-fs#69

@tmcw
Copy link
Member

tmcw commented Nov 29, 2015 

# using node v5.1.0
~/src/documentation〉node -e "console.log('a'.localeCompare('B'))"
31
~/src/documentation〉nvm use v5
Now using node v5.1.0 (npm v3.3.12)
~/src/documentation〉node -e "console.log('a'.localeCompare('B'))"
-1

@tmcw tmcw mentioned this issue Dec 1, 2015
Closed
@tmcw
Copy link
Member

tmcw commented Dec 1, 2015

Implemented in d069b6a

@tmcw tmcw closed this as completed Dec 1, 2015
rhendric pushed a commit to rhendric/documentation that referenced this issue Sep 15, 2022
@andyarvanitis @hdgarrood
Update purescript-native version to v0.13.x (documentationjs#253)
4ac62b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmcw @jfirebaugh