-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error handling when misuse of find() with array values #11285
base: 3.4.x
Are you sure you want to change the base?
Conversation
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble. How to do that?
|
9fe5225
to
e4d6329
Compare
@greg0ire I rebased the PR as you suggested. But now I have this BackedEnum check coming from foreach ($identifier as $k => $value) {
if ($value instanceof BackedEnum) {
$identifier[$k] = $value->value;
}
} I thought you said it was redundant so I am confused... |
In the interactive rebase window, you can drop any commit you feel is unnecessary… I don't know how you managed to make them appear. |
Issue
When we (inexpertly) use
$em->find(...)
with array values in identifer, it returns a PHP warning..See all details and how to reproduce it in the issue : #11236.
Solution
In this PR
Notes
This PR is a copy of this PR who has been re-targeted to branch
3.1.x