fix: always cleanup in AbstractHydrator::toIterable()
#11101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please add a test? |
Closed
simPod
force-pushed
the
cleanup
branch
2 times, most recently
from
0e5e318
to
aa4961e
Compare
|
@oleg-andreyev thank you. I have incorporated your test into the PR and cleaned it up. |
|
@derrabus psalm failures seems irrelevant |
|
@simPod you are targeting an unmaintained branch. |
|
Retargeted, please address the conflicts. |
|
done, thanks |
|
No more Psalm failures :) |
|
Please squash both commits and improve your commit message according to the contributing guide. |
derrabus
approved these changes
Apr 25, 2024
|
While you're at it, please add the author of the test using a |
|
sure, done |
Previously it didn't cleanup anything as long as the iteration hasn't reached the final row. Co-authored-by: Oleg Andreyev <oleg.andreyev@lampa.lv>
|
Thank you! |
derrabus
added a commit
that referenced
this pull request
May 21, 2024
* 3.2.x: Using an integer as discriminator value with ORM v3 Using an integer as discriminator value with ORM v3 Bump ramsey/composer-install from 2 to 3 (#11442) Use ramsey/composer-install in PHPBench workflow (#11444) Bump doctrine/.github from 3.0.0 to 5.0.1 Upgrade codecov/codecov-action Setup Dependabot Make test compatible with PHP 7.1 Fix deprecation layer Remove unused test group Keep entities in identity map until the scheduled deletions are executed. Update association-mapping.rst fix: always cleanup in `AbstractHydrator::toIterable()` (#11101) Respect orderBy for EAGER fetch mode fix(docs): typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6480
Closes #11419