Run tests on sharded clusters #2272
Conversation
| runs-on: "${{ matrix.os }}" | ||
|
|
||
| strategy: | ||
| matrix: | ||
| os: | ||
| - "ubuntu-20.04" | ||
| - "ubuntu-18.04" |
There was a problem hiding this comment.
Note: going back to 18.04 as drivers-evergreen-tools only supports MongoDB 4.4 on 20.04. 18.04 supports MongoDB 4.0, 4.2, and 4.4.
| @@ -46,6 +46,8 @@ public function testHintIsNotSetByDefault() | |||
| */ | |||
| public function testHintIsSetOnQuery($readPreference, array $tags = []) | |||
| { | |||
| $this->skipTestIfSharded(User::class); | |||
There was a problem hiding this comment.
The sharded cluster uses a single-member replica set, so a functional test that runs a find with a secondary read preference always fails.
| deps: | ||
| - "normal" | ||
| include: | ||
| - deps: "low" | ||
| os: "ubuntu-20.04" | ||
| os: "ubuntu-16.04" |
There was a problem hiding this comment.
Hopefully this image won't disappear before MongoDB ends support for 3.6 in April :)
| { | ||
| $result = $this->dm->getDocumentDatabase($className)->command(['listCommands' => true])->toArray()[0]; | ||
| if (! $result['ok']) { | ||
| $this->markTestSkipped('Could not check whether server supports sharding'); |
There was a problem hiding this comment.
Shouldn't this one be marked as risky as we can't determine if the test should run or not? This will be easier to spot than S which already is showing up in the results.
There was a problem hiding this comment.
I can also throw an exception to let the test fail: if we can't run listCommands this warrants further investigation.
There was a problem hiding this comment.
I've removed the check entirely: the command method already throws an exception for failed commands, so the checks are total unnecessary. I've removed them.
|
As for |
Summary
This part of the pipeline was dropped when we moved from travis-ci to GH actions. This now uses the (definitely unsupported) mongodb-labs/drivers-evergreen-tools repository to launch MongoDB clusters of any version/topology.