Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.3 #81

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Allow PHP 8.3 #81

merged 1 commit into from
Nov 21, 2023

Conversation

driehle
Copy link
Member

@driehle driehle commented Nov 16, 2023

This PR adds support for PHP 8.3. Fortunately, all dependencies of this library are already PHP 8.3-compatible, so this step is pretty straight forward.

Minimum constraints for doctrine/collections has been raised to ensure that BC-layer is always present in 2.x series. Minimum constraint for laminas-hydrator and laminas-stdlib has been raised to lowest versions supporting PHP 8.0, so that change is only of cosmetic nature (but makes maintenance easier and, hence, should be made).

@driehle driehle added the Enhancement New feature or request label Nov 16, 2023
@driehle driehle added this to the 3.4.0 milestone Nov 16, 2023
@driehle driehle requested a review from a team November 16, 2023 12:45
@TomHAnderson
Copy link
Member

Correct me if I'm wrong, but shouldn't coding standards be checked at lowest: 8.0?

@driehle
Copy link
Member Author

driehle commented Nov 21, 2023

@TomHAnderson

Correct me if I'm wrong, but shouldn't coding standards be checked at lowest: 8.0?

No, that's not necessary. The minimal version compatibilty is set in phpcs.xml.dist and php-cs will adhere to that setting. Therefore, its better to run the coding standards with new newest PHP version to detect errors early.

<!-- set minimal required PHP version (7.4) -->
<config name="php_version" value="70400"/>

For Psalm and PHPStan the same holds true, though they infer the PHP versions automatically be checking the composer.json file. For Psalm its possible to specify the minimum PHP version in the config, but we do not use that feature, as an automatic inflection from the composer file is more convenient and reliable.

The minimum version for php-cs will be raised within #82.

@driehle driehle merged commit f6ba27a into doctrine:3.4.x Nov 21, 2023
12 checks passed
@driehle driehle deleted the php83 branch November 21, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants