Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for enums via use of strategies #59

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

driehle
Copy link
Member

@driehle driehle commented Jun 10, 2022

This a rebased version of #57 bringing support for enum via strategies

@driehle driehle requested review from greg0ire and a team June 10, 2022 11:23
@driehle driehle self-assigned this Jun 10, 2022
@driehle driehle added the Enhancement New feature or request label Jun 10, 2022
@driehle driehle added this to the 3.1.0 milestone Jun 10, 2022
src/DoctrineObject.php Outdated Show resolved Hide resolved
tests/Assets/SimpleEnum.php Outdated Show resolved Hide resolved
tests/DoctrineObjectTest.php Outdated Show resolved Hide resolved
tests/Assets/SimpleEnumStrategy.php Outdated Show resolved Hide resolved
tests/Assets/SimpleEnum.php Outdated Show resolved Hide resolved
tests/Assets/SimpleEntityWithEnum.php Outdated Show resolved Hide resolved
tests/DoctrineObjectTest.php Show resolved Hide resolved
tests/DoctrineObjectTest.php Outdated Show resolved Hide resolved
tests/DoctrineObjectTest.php Outdated Show resolved Hide resolved
src/DoctrineObject.php Outdated Show resolved Hide resolved
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@driehle driehle linked an issue Jun 10, 2022 that may be closed by this pull request
@driehle driehle merged commit b325ac2 into doctrine:3.1.x Jun 10, 2022
@HeyRatFans
Copy link
Contributor

I'm glad someone finally worked out the psalm/php-cs issues. Kudos @driehle 😄

@driehle driehle deleted the enum-support branch June 12, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backed Enum Hydration ends up in a type conversion
3 participants