Fix max string length resolution in AbstractPlatform::getEnumDeclaration()
#6579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Please add a test. |
davidxkurka
force-pushed
the
fix/get-enum-declaration-sql-method
branch
2 times, most recently
from
128fdeb to
96c75db
Compare
davidxkurka
force-pushed
the
fix/get-enum-declaration-sql-method
branch
from
96c75db to
6bdd70a
Compare
|
@derrabus Hi, tests done. |
derrabus
approved these changes
Nov 24, 2024
|
Thank you! |
derrabus
changed the title
AbstractPlatform::getEnumDeclaration()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a situation where an enum type only contains 1 case. This results in passing only a single integer argument to the max() method, which is not valid and returns the error "max(): Argument 1 ($value) must be of type array, int given".