doctrine:migration:diff does not work if the table has an index with a functional part.

[prohalexey]

Q	A
Type	bug

Summary

if the table has an index with a functional part, command doctrine:migration:diff fails with error

In Index.php line 81:
                                                                               
  Doctrine\DBAL\Schema\Index::_addColumn(): Argument #1 ($column) must be of   
  type string, null given, called in /opt/core/vendor/doctrine/dbal/src/Schem  
  a/Index.php on line 72 

That's because column name for the functional part is null.

[derrabus]

Thank you. Please note that we don't merge any changes without tests.

[prohalexey]

@derrabus What tests do you think will be suitable for this patch?

[derrabus]

A test that reproduces your issue and fails without your change.

[derrabus]

Please add functional tests. The tests you've added never hit a real database and thus don't tell us that your feature actually works.

[prohalexey]

@derrabus Could you give some advice or explanations about falling tests? I tried running tests on my local machine against postgresql and mysql and they passed. As I see, there is a lot of errors, and i don't see the correlation between the errors and my code. What could be a root cause of problem ?

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

[github-actions]

This pull request was closed due to inactivity.