Remove PostgreSQLPlatform::isNumericType() #5394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
commented
May 14, 2022
| @@ -891,7 +891,6 @@ public function testAltersTableColumnCommentIfRequiredByType(): void | |||
| self::assertSame( | |||
| [ | |||
| 'ALTER TABLE "foo" ALTER "bar" TYPE TIMESTAMP(0) WITHOUT TIME ZONE', | |||
| 'ALTER TABLE "foo" ALTER "bar" DROP DEFAULT', | |||
There was a problem hiding this comment.
There's no reason to expect this statement. It's probably expected because at the time of writing the test the schema comparison already worked like this.
morozov
commented
May 14, 2022
|
|
||
| private function isNumericType(Type $type): bool | ||
| { | ||
| return $type instanceof IntegerType || $type instanceof BigIntType; |
There was a problem hiding this comment.
This is likely the source of other bugs. E.g. if there is a custom type that uses an integer type instance to define its schema but doesn't extend it, it won't be detected as such.
greg0ire
approved these changes
May 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the logic that tests the column type against specific types. The default value should be altered only if it has changed. If the new type is incompatible with the old default value, the new default value should be specified explicitly.
Although this is a bug fix, it may affect some use cases that rely on the existing behavior, so let's include it in the minor, not a patch release. A safer hotfix is implemented in #5395.