Merge release 2.11.1 into 3.0.x #4303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Although the official docs [1] show examples of definition list with an indent of 2 spaces, it seems that doctrine/rst-parser has been written with an indent of 4 spaces in mind. [2] This should ensure the definition lists are properly parsed as such, right now they are parsed as paragraphs. [1] https://docutils.sourceforge.io/docs/user/rst/quickref.html#definition-lists [2] https://github.com/doctrine/rst-parser/blob/d97da75a8a2cab33453711f01b90303f5c3845db/lib/Parser/LineDataParser.php#L154
Link to contributing guide
Increase indent in definition lists
morozov
approved these changes
Sep 27, 2020
morozov
deleted the
2.11.x-merge-up-into-3.0.x_5f7016a137fdb7.25092246
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 2.11.1
2.11.1
Documentation
SQLite,Test Suite,pdo_sqlite
4297: Fix ExceptionTest::testConnectionExceptionSqLite() on macOS thanks to @morozov
4296: Increase indent in definition lists thanks to @greg0ire
Deprecation,Prepared Statements
BC Fix,Quoting
BC Fix,Query
Bug,Documentation,Prepared Statements
Bug,PDO,Prepared Statements