Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped SQL Server 2008 support #3756

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Conversation

morozov
Copy link
Member

@morozov morozov commented Nov 28, 2019

Q A
Type improvement
BC Break yes

Fixes #3755.

Additionally, some changes in .appveyor.yml were needed in order to work around the build failure. The reason is:

  1. Due to Not all package versions are returned when running running choco list --all-versions --exact chocolatey/choco#1843, choco search only returns PHP 7.4.0 as of today:
    PS C:\Users\Sergei Morozov> choco search php --exact --all-versions
    Chocolatey v0.10.15
    php 7.4.0 [Approved]
    1 packages found.
    
  2. Combined with | select-string -pattern 7.3, it yields an empty list and fails the build.
  3. Prior to this change, the builds would pass because all runtime dependencies are cached based on the content of .appveyor.yml.
  4. We cannot switch to PHP 7.4 on AppVeyor because the corresponding sqlsrv and pdo_sqlsrv binaries are not yet available.

Chocolatey returns only 7.4.0 in the search results but there's no SQL Server extensions released for it yet.
@SenseException
Copy link
Member

Are we going to create a new PR for having sqlsrv and pdo_sqlsrv with PHP 7.4 when it is available? Or do you want to try to find another solution?

@morozov
Copy link
Member Author

morozov commented Dec 5, 2019

Are we going to create a new PR for having sqlsrv and pdo_sqlsrv with PHP 7.4 when it is available? Or do you want to try to find another solution?

Apparently, the 5.7.1preview builds are compiled for PHP 7.4 but I'd rather solve one problem at a time.

@morozov morozov merged commit a901523 into doctrine:master Dec 5, 2019
@morozov morozov deleted the issues/3755 branch December 5, 2019 23:39
@beberlei
Copy link
Member

beberlei commented Dec 7, 2019

@morozov this needs to get into 2.10 as well as appveyor is mass failing there as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for SQL Server 2008
3 participants