Fix parsing SQLite FK reference not containing whitepace

doctrine · Aug 17, 2022 · f62eeba · f62eeba
1 parent 94e0164
commit f62eeba
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/Schema/SqliteSchemaManager.php b/src/Schema/SqliteSchemaManager.php
@@ -626,7 +626,7 @@ private function getForeignKeyDetails($table)
                 '#
                     (?:CONSTRAINT\s+(\S+)\s+)?
                     (?:FOREIGN\s+KEY[^)]+\)\s*)?
-                    REFERENCES\s+\S+\s+(?:\([^)]+\))?
+                    REFERENCES\s+\S+\s*(?:\([^)]+\))?
                     (?:
                         [^,]*?
                         (NOT\s+DEFERRABLE|DEFERRABLE)

diff --git a/tests/Functional/Schema/SqliteSchemaManagerTest.php b/tests/Functional/Schema/SqliteSchemaManagerTest.php
@@ -274,4 +274,32 @@ public function testIntrospectMultipleAnonymousForeignKeyConstraints(): void
         self::assertSame(['artist_id'], $foreignKey2->getLocalColumns());
         self::assertSame(['id'], $foreignKey2->getForeignColumns());
     }
+
+    public function testNoWhitespaceInForeignKeyReference(): void
+    {
+        $this->dropTableIfExists('notes');
+        $this->dropTableIfExists('users');
+
+        $ddl = <<<'DDL'
+        CREATE TABLE "users" (
+            "id" INTEGER
+        );
+
+        CREATE TABLE "notes" (
+            "id" INTEGER,
+            "created_by" INTEGER,
+            FOREIGN KEY("created_by") REFERENCES "users"("id"));
+        DDL;
+
+        $this->connection->executeStatement($ddl);
+        $notes = $this->schemaManager->listTableDetails('notes');
+
+        $foreignKeys = $notes->getForeignKeys();
+        self::assertCount(1, $foreignKeys);
+
+        $foreignKey = array_shift($foreignKeys);
+        self::assertSame(['created_by'], $foreignKey->getLocalColumns());
+        self::assertSame('users', $foreignKey->getForeignTableName());
+        self::assertSame(['id'], $foreignKey->getForeignColumns());
+    }
 }