handle older versions of phpcr-odm #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @Ocramius |
|
Related to #165 |
|
👍 Also not really testable :-( |
|
true that. we could mock the DocumentManager without transactional to test it... |
|
@dbu I don’t really see the point, it’s fine like this. Also, the test failing would mean a fatal error. |
|
well rather a fatal error in test than for end users :-) but i am fine if we can merge like this and tag a patch release for it soon. people following the cmf tutorials currently end up with fatal errors until 1.1.1 is released. |
lavoiesl
added a commit
that referenced
this pull request
Mar 30, 2015
handle older versions of phpcr-odm
|
Released as 1.1.1, thanks. |
|
great, thanks you!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpcr-odm only got transactional added in a recent version. we get symfony-cmf/symfony-cmf#217
the alternative would be to declare a
conflictsin composer.json to force using a version of phpcr-odm that has transactional.