Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quoting of "joinTable" table names in ORMPurger #180

Merged
merged 1 commit into from
Mar 23, 2015
Merged

Fix Quoting of "joinTable" table names in ORMPurger #180

merged 1 commit into from
Mar 23, 2015

Conversation

lavoiesl
Copy link
Member

Fixes #139

@lavoiesl lavoiesl added the Bug label Mar 22, 2015
@lavoiesl lavoiesl added this to the 1.0.1 milestone Mar 22, 2015
@Ocramius
Copy link
Member

@lavoiesl this needs an additional test case as well

@lavoiesl
Copy link
Member Author

True that.

* @param \Doctrine\DBAL\Platforms\AbstractPlatform $platform
* @return array
*/
private function getAssociationTables(array $classes, $platform)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the argument should be typehinted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

lavoiesl added a commit that referenced this pull request Mar 23, 2015
Fix Quoting of "joinTable" table names in ORMPurger
@lavoiesl lavoiesl merged commit 1d3baab into doctrine:master Mar 23, 2015
@lavoiesl lavoiesl deleted the ORMPurger-QuoteJoinTableName branch March 23, 2015 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants