Allowing getReference to detect when the reference does not exist. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the reference requested does not exist, the $reference variable is NULL which cause the "$this->manager->getClassMetadata(get_class($reference));" line to attempt to get the metadata for Doctrine\Common\DataFixtures\ReferenceRepository (default because $referenceis NULL) rather than the class of the reference object.
| */ | ||
| public function getReference($name) | ||
| { | ||
| $reference = $this->references[$name]; | ||
| if (is_null($reference)) |
There was a problem hiding this comment.
CS issues: please use null === to check for null and please add the curly braces for the conditional structure
|
Please also add a test for it |
|
Still need to add a test. Will take care of tomorrow. |
|
@stof The test was added. |
|
@stof, DId you get a chance to review this? |
| */ | ||
| public function getReference($name) | ||
| { | ||
| $reference = $this->references[$name]; | ||
| if (null === $reference) | ||
| throw new \InvalidArgumentException("Reference to: ({$name}) does not exist, use method hasReference in order to check for existance"); |
There was a problem hiding this comment.
This check should be done before reading the reference, using isset($this->references[$name]) instead, to avoid a NOTICE when the reference does not exist
|
Fixed by #179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the reference requested does not exist, the $reference variable is NULL which cause the "$this->manager->getClassMetadata(get_class($reference));" line to attempt to get the metadata for Doctrine\Common\DataFixtures\ReferenceRepository (default because $referenceis NULL) rather than the class of the reference object.