Add support for union types and mixed type in ProxyGenerator #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beberlei
commented
Nov 26, 2020
beberlei
commented
Nov 26, 2020
greg0ire
reviewed
Nov 26, 2020
greg0ire
reviewed
Nov 27, 2020
greg0ire
reviewed
Nov 27, 2020
|
BTW if you need any help with PHPStan, don't hesitate to reach me directly instead of speculating over less than ideal solutions... |
|
Will ping you directly from now on ^^ |
greg0ire
force-pushed
the
Php8support
branch
3 times, most recently
from
9a5402c to
7204aae
Compare
greg0ire
reviewed
Nov 29, 2020
| function (ReflectionType $unionedType) use ($method, $parameter) { | ||
| return $this->formatType($unionedType, $method, $parameter); | ||
| }, | ||
| $type->getTypes() |
There was a problem hiding this comment.
CodeCov says the lines are not covered, and it is correct: there is no PHP 8 job yet. I'll try to add one in a different PR, as well as the other minor improvements I added that pollute this PR.
greg0ire
force-pushed
the
Php8support
branch
3 times, most recently
from
237a831 to
62ea166
Compare
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
greg0ire
force-pushed
the
Php8support
branch
from
62ea166 to
39cfef4
Compare
That code cannot run on PHP8+
greg0ire
force-pushed
the
Php8support
branch
from
39cfef4 to
b5f3cd5
Compare
greg0ire
approved these changes
Dec 3, 2020
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for generating proxies for classes using the following new PHP 8 syntax constructs: