Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CI build for just DBAL without ORM #1708

Merged
merged 2 commits into from
Oct 18, 2023
Merged

add CI build for just DBAL without ORM #1708

merged 2 commits into from
Oct 18, 2023

Conversation

dmaicher
Copy link
Contributor

No description provided.

@dmaicher dmaicher force-pushed the dbal_only_ci branch 2 times, most recently from f67a2bf to 7b1c44a Compare October 17, 2023 10:40
@dmaicher dmaicher marked this pull request as ready for review October 17, 2023 10:42
@dmaicher dmaicher mentioned this pull request Oct 17, 2023
Merged
stof
stof reviewed Oct 17, 2023
View reviewed changes
.github/workflows/continuous-integration.yml
- php-version: "8.2"
dependencies: "highest"
stability: "stable"
remove-orm: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on #1707 about the matrix.

@dmaicher dmaicher added this to the 2.11.0 milestone Oct 17, 2023
@dmaicher dmaicher requested a review from ostrolucky October 17, 2023 10:46
ostrolucky
ostrolucky approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should he been part of 2.10.x though

@dmaicher
Copy link
Contributor Author

Should he been part of 2.10.x though

I can also rebase it on 2.10.x 👍

@dmaicher dmaicher changed the base branch from 2.11.x to 2.10.x October 18, 2023 12:13
@dmaicher dmaicher modified the milestones: 2.11.0, 2.10.3 Oct 18, 2023
@dmaicher
Copy link
Contributor Author

Hm interesting test fails

 1) Doctrine\Bundle\DoctrineBundle\Tests\ProfilerTest::testRender
Twig\Error\RuntimeError: Variable "profile_type" does not exist.

/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/symfony/web-profiler-bundle/Resources/views/Profiler/layout.html.twig:5
/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/twig/twig/src/Template.php:171
/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/twig/twig/src/Template.php:394
/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/twig/twig/src/Template.php:367
/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/twig/twig/src/Template.php:394
/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/twig/twig/src/Template.php:367
/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/twig/twig/src/Template.php:394
/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/twig/twig/src/Template.php:367
/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/twig/twig/src/Template.php:379
/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/twig/twig/src/TemplateWrapper.php:40
/home/runner/work/DoctrineBundle/DoctrineBundle/vendor/twig/twig/src/Environment.php:280
/home/runner/work/DoctrineBundle/DoctrineBundle/Tests/ProfilerTest.php:97

maybe related to the CLI profiler changes on 6.4? 🤔

@dmaicher dmaicher requested a review from ostrolucky October 18, 2023 12:23
@ostrolucky ostrolucky merged commit b1ff934 into doctrine:2.10.x Oct 18, 2023
@dmaicher dmaicher deleted the dbal_only_ci branch October 18, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@ostrolucky ostrolucky Awaiting requested review from ostrolucky

Assignees
No one assigned
Labels
CI Test Suite
Projects
None yet
Milestone
2.10.3
Development

Successfully merging this pull request may close these issues.
4 participants
@dmaicher @stof @ostrolucky @derrabus