-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Composer Lint" job to CI pipeline #1540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rather embed this in https://github.com/doctrine/DoctrineBundle/blob/2.7.x/.github/workflows/coding-standards.yml?
Hmm maybe we should have this in https://github.com/doctrine/.github/blob/main/.github/workflows/coding-standards.yml so it applies for all projects, cc @greg0ire |
I think it could indeed be contributed to that repo. If we add it to the CS workflow. If we do that, the next release should probably be 2.0.0 to make it clear that an action must be taken to make the build green (fixing |
bfe4c99
to
0b3b264
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Applies
composer-lint
workflow from doctrine/.github.