implement EntityManagerProvider and use for ORM proxy commands #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
commented
Apr 26, 2022
dmaicher
force-pushed
the
orm_command_entity_manager_provider
branch
2 times, most recently
from
2cc8311
to
b397ec3
Compare
ostrolucky
reviewed
May 5, 2022
dmaicher
force-pushed
the
orm_command_entity_manager_provider
branch
5 times, most recently
from
0c42ab8
to
9b4bc09
Compare
dmaicher
commented
May 9, 2022
|
|
||
| class InfoDoctrineCommandTest extends TestCase | ||
| { | ||
| public function testExecute(): void | ||
| { | ||
| $kernel = $this->setupKernelMocks(); | ||
| $kernel = new TestKernel(); |
There was a problem hiding this comment.
made this a functional test instead
dmaicher
force-pushed
the
orm_command_entity_manager_provider
branch
from
9b4bc09
to
a1bcf33
Compare
ostrolucky
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1509