Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop master #1507

Merged
merged 1 commit into from
Apr 14, 2022
Merged

refactor: drop master #1507

merged 1 commit into from
Apr 14, 2022

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Apr 13, 2022

I decided to clean up the mess caused by dropping standard master-slave naming. Should I clean slaves as well?

@stof
Copy link
Member

stof commented Apr 13, 2022

This cannot be done in a minor version.

@stof
Copy link
Member

stof commented Apr 13, 2022

ah, actually, it can as this only cleans the parameters passed from the bundle to DBAL (and so it is fine if the bundle requires DBAL 2.11+). but only if this still works when users of the bundle have not updated their config yet (I don't remember whether the bundle normalizes the config between master and primary).

@simPod
Copy link
Contributor Author

simPod commented Apr 14, 2022

I have removed all master appearances. So I don't think there's any normalization. DBAL requires primary https://github.com/doctrine/dbal/blob/2.11.3/lib/Doctrine/DBAL/Connections/PrimaryReadReplicaConnection.php#L106

@ostrolucky ostrolucky added this to the 2.6.3 milestone Apr 14, 2022
@ostrolucky ostrolucky merged commit 4f4387c into doctrine:2.6.x Apr 14, 2022
@simPod simPod deleted the drop-master branch April 14, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants