Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register remember me schema subscriber from Symfony Bridge #1297

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Register remember me schema subscriber from Symfony Bridge #1297

merged 1 commit into from
Apr 16, 2021

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Feb 25, 2021 •
edited
Loading

This PR registers the RememberMeTokenProviderDoctrineSchemaSubscriber schema listener that will be introduced in symfony/symfony#40145 . This way, Doctrine's schema system can help the user create and update their remember me table.

stof
stof requested changes Feb 25, 2021
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This service definition should be conditional, to keep support for Symfony versions not having it (the bundle supports the 4.4 LTS too)

@wouterj wouterj force-pushed the security-doctrine-token-provider branch from 6e48117 to bdcc6c3 Compare February 25, 2021 11:17
@wouterj wouterj force-pushed the security-doctrine-token-provider branch from bdcc6c3 to d96e588 Compare February 25, 2021 11:22
@wouterj
Copy link
Contributor Author

wouterj commented Feb 25, 2021

Thanks for the quick review @stof! The definition is optional now.

@ostrolucky ostrolucky added this to the 2.3.0 milestone Feb 25, 2021
@ostrolucky ostrolucky added the Status: On Hold Most likely waiting for upstream resolution label Feb 25, 2021
@ostrolucky ostrolucky mentioned this pull request Mar 16, 2021
Merged
@ostrolucky ostrolucky removed this from the 2.3.0 milestone Mar 20, 2021
@ostrolucky ostrolucky changed the base branch from 2.3.x to 2.4.x March 20, 2021 08:52
@wouterj wouterj mentioned this pull request Mar 23, 2021
Merged
3 tasks
@wouterj wouterj changed the title [Waiting code merge] Register remember me schema subscriber from Symfony Bridge Register remember me schema subscriber from Symfony Bridge Apr 11, 2021
@wouterj
Copy link
Contributor Author

wouterj commented Apr 11, 2021

The related Symfony PR has been merged and it will be part of the upcoming 5.3 release. So I think this PR is ready to be merged.

@ostrolucky ostrolucky removed the Status: On Hold Most likely waiting for upstream resolution label Apr 12, 2021
@ostrolucky ostrolucky added this to the 2.4.0 milestone Apr 12, 2021
@ostrolucky ostrolucky merged commit 79f11f8 into doctrine:2.4.x Apr 16, 2021
@wouterj wouterj deleted the security-doctrine-token-provider branch April 16, 2021 16:13
@ostrolucky ostrolucky mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof requested changes

@ostrolucky ostrolucky ostrolucky approved these changes

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wouterj @stof @ostrolucky @SenseException