Logging: allow disabling logging for all connections

doctrine · Apr 5, 2022 · 6026f74 · 6026f74
1 parent b700275
commit 6026f74
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/Resources/config/middlewares.xml b/Resources/config/middlewares.xml
@@ -8,7 +8,6 @@
         <service id="doctrine.dbal.logging_middleware" class="Doctrine\DBAL\Logging\Middleware" abstract="true">
             <argument type="service" id="logger" />
             <tag name="monolog.logger" channel="doctrine" />
-            <tag name="doctrine.middleware" />
         </service>
     </services>
 </container>
diff --git a/Tests/DependencyInjection/DoctrineExtensionTest.php b/Tests/DependencyInjection/DoctrineExtensionTest.php
@@ -1223,6 +1223,35 @@ public function testDefinitionsToLogQueries(bool $withMiddleware, bool $loggerIn
         $this->assertFalse(in_array(['connection' => 'conn2'], $middleWareTagAttributes, true), 'Tag with connection conn2 found');
     }
 
+    public function testDefinitionsToLogQueriesLoggingFalse(): void
+    {
+        /** @psalm-suppress UndefinedClass */
+        if (! class_exists(Middleware::class)) {
+            $this->markTestSkipped(sprintf('%s needs %s to not exist', __METHOD__, Middleware::class));
+        }
+
+        $container = $this->getContainer();
+        $extension = new DoctrineExtension();
+
+        $config = BundleConfigurationBuilder::createBuilderWithBaseValues()
+            ->addConnection([
+                'connections' => [
+                    'conn' => [
+                        'password' => 'foo',
+                        'logging' => false,
+                    ],
+                ],
+            ])
+            ->addBaseEntityManager()
+            ->build();
+
+        $extension->load([$config], $container);
+
+        $this->assertTrue($container->hasDefinition('doctrine.dbal.logging_middleware'));
+        $abstractMiddlewareDefTags = $container->getDefinition('doctrine.dbal.logging_middleware')->getTags();
+        $this->assertArrayNotHasKey('doctrine.middleware', $abstractMiddlewareDefTags);
+    }
+
     // phpcs:enable
 
     /** @param list<string> $bundles */