Allow locking the deps #58
Merged
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On doctrine/website, which is a regular Symfony application, we put the composer.lock under version control, as we should. In order to be able to have the same experience in the CI as we have locally, we should use the same version of the dependencies. To that end, let's allow passing the dependency-versions option to ramsey/composer-install on workflows that are reused on doctrine/website.
greg0ire
requested review from
beberlei,
morozov,
alcaeus,
stof,
ostrolucky,
SenseException,
derrabus and
malarzm
ostrolucky
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
doctrine/website, which is a regular Symfony application, we put thecomposer.lockunder version control, as we should. In order to be able to have the same experience in the CI as we have locally, we should use the same version of the dependencies. To that end, let's allow passing thedependency-versionsoption toramsey/composer-installon workflows that are reused ondoctrine/website.Proofs
We can see that the option is taken into account in the following logs: