Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Reference extension #1320

Closed
wants to merge 4 commits into from
Closed

Conversation

dbojdo
Copy link

@dbojdo dbojdo commented May 28, 2015

No description provided.

@l3pp4rd
Copy link
Contributor

l3pp4rd commented Jun 10, 2015

could you add a reference test to prevent regression?

@dbojdo
Copy link
Author

dbojdo commented Jun 11, 2015

Test is already there. See: dbojdo@54b19d5#diff-69d5143cc504ebc2545a7dd48968cd34

Or do you mean the other kind of tests?

@l3pp4rd
Copy link
Contributor

l3pp4rd commented Jun 11, 2015

ah, missed that it has changed to registries, well, that is backward incompatible change. will need to delay it till 2.5 version. have set a milestone

@l3pp4rd l3pp4rd added this to the Arya Stark milestone Jun 11, 2015
@l3pp4rd l3pp4rd modified the milestones: 2.5.0, Arya Stark Oct 2, 2015
@prolic
Copy link

prolic commented Jan 13, 2017

This PR is kind of old already. Any reason why it's not merged, yet?

@l3pp4rd
Copy link
Contributor

l3pp4rd commented Jan 13, 2017

it is backward incompatible. I doubt that extensions will make any BC changes, it will stay stable

@AkenRoberts
Copy link
Member

Hello, and thank you for your contribution.

In the interest of spring cleaning and package modernization, I'm going through and closing old issues and pull requests that have had no recent activity, do not have associated tests, or have failing tests.

If you are still experiencing this issue or wish to contribute an up-to-date pull request, please create a new issue.

Thank you!

@AkenRoberts AkenRoberts closed this Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants