Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve external script plugin #632

Merged

Conversation

slengyel-lnx
Copy link
Contributor

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

External script plugin does not set data- attributes. It would be better if Element.setAttribute() method would be used. This would solve my issue.

Checked in Chrome Version 69.0.3497.100 (Official Build) (64-bit) / Ubuntu 18.04

I understand that it's not accepted to create pull request with lib files, but it would be a nice improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants