[Release]: v4.11.4 #1190

anikethsaha · 2020-05-22T10:10:19Z

Do Not Merge

Changelog

...

Blocking

update: added html sanitizer for remote rendering #1128
style: Get emoji from github api #1188
Dependency DOMpurify is not able to bundled with the output.

Any rollup expert can tackle this ?

Snyk has created this PR to upgrade docsify from 4.10.2 to 4.11.2. See this package in NPM: https://www.npmjs.com/package/docsify See this project in Snyk: https://app.snyk.io/org/anikethsaha/project/6efe7e04-4e52-497e-8ad5-570733cc577a?utm_source=github&utm_medium=upgrade-pr

…4c39a1be1464a76e [Snyk] Upgrade docsify from 4.10.2 to 4.11.2

…dded token results returning in any order fixes #970

fix bug #1110

fix bug #1098

[fix #1115] Image resize in % doesn't work.

* fix * Update search.js * Update search.js * Update search.js * Update search.js * Update search.js

Update embeded files documentation Add example with front matter Add various comments I used to understand code Updated front matter to have installed flag Added function to parse front matter Added intercept to remove front matter for embed

Fix #1136 and #1127

Also, add a link explaining why that can be a security issue.

Fix typo on `externalLinkRel`

…ility Improve accessibility of viewport meta by allowing page zoom (related to #945)

Updated embed to strip YAML front matter fixes #1129

fix Edit Document

codesandbox-ci · 2020-06-08T07:40:16Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 714ef29:

Sandbox	Source
ecstatic-lake-wse4x	Configuration

…ned search bar using docsify-darklight-theme" (#1207) * Revert "update: updated docs site dark and light mode with switch and redesigned search bar using docsify-darklight-theme (#1182)" This reverts commit 415f295. * docs: removed the old dark mode as well

…r ports

trusktr · 2020-06-10T19:03:51Z

it has been merged and it will be shipped with this release.

Great Thanks !

@boopathikumar018 The change was reverted, as @jhildenbiddle brought up some good points, along with a breaking change in IE 11. (we need to improve PRs to have testing for all browsers). See there for some ideas: hoping you can implement a subset of the PR with an option for users to specify light and dark themes, then your theme changes can come in following PR.

chore: remove redundant instruction from lint-staged config

* develop: chore: update auto format config

Co-authored-by: James George <jamesgeorge998001@gmail.com>

Allow configs to be functions

* Fix cover overlapping sidebar * Fix transition of cover page * Revmove transition property from .cover * Remove z-index attribute from _coverpage.styl

Co-authored-by: Joe Pea <joe@trusktr.io>

anikethsaha · 2020-06-17T18:26:43Z

All blockers are fixed.

Ready to release once CI is green.

anikethsaha · 2020-06-18T15:03:12Z

@trusktr @jhildenbiddle @Koooooo-7 @sy-records we have a new blocker

trusktr · 2020-06-18T17:05:34Z

I could've sworn I added a test to ensure the bundle is loaded properly. Need to improve that test. See docsify.test.js

trusktr · 2020-06-18T17:09:46Z

This is the file: https://www.github.com/docsifyjs/docsify/tree/develop/test%2Funit%2Fdocsify.test.js

npm test does a prod build then runs that test. If that test is passing, it means the bundle loads fine, but maybe it fails once we try it do something on the site?

We can use window.addEventListener('error', ...) to observe uncaught errors at the top level (f.e. in the test file).

trusktr · 2020-06-18T17:12:42Z

Didn't it work in the preview? And tests passed? Did you perhaps need to run npm install? Or does this happen even after install? And if so, then how did the PR pass testing?

anikethsaha · 2020-06-18T18:02:06Z

Thanks for the heads up @trusktr , I actually had 2-3 docsify code opened in my machine, ran npm install in one, ran the build command in other 😄

trusktr · 2020-06-18T18:04:32Z

Hehe. Happens to the best of us. I can't count how many times I've done something like that. ;)

snyk-bot and others added 30 commits March 31, 2020 21:31

Merge pull request #1099 from docsifyjs/snyk-upgrade-82b6c6427661ce91…

957609a

…4c39a1be1464a76e [Snyk] Upgrade docsify from 4.10.2 to 4.11.2

updated the insertion of embedded tokens so it correctly handles embe…

ea17dcc

…dded token results returning in any order fixes #970

chore: update auto format config

96d5b19

Update sidebar.js

d32d91b

fix bug #1110

Update component.js

b4e7b21

fix bug #1098

[fix #1115] Image resize in % doesn't work.

517f0d7

Merge pull request #1116 from docsifyjs/fix1115

39320bb

[fix #1115] Image resize in % doesn't work.

Linting Checks

fed6a83

Linting Checks

1c43abe

fix: Inconsistent search and body rendering

dcb0aae

* fix * Update search.js * Update search.js * Update search.js * Update search.js * Update search.js

Update nameLink option docs (#1125)

b2e6123

Update index.html (#1144)

2623b94

reset and modify.

b108c86

fix: rendering cover width bug

717991c

Add front matter to dev page

b05949a

Update embeded files documentation Add example with front matter Add various comments I used to understand code Updated front matter to have installed flag Added function to parse front matter Added intercept to remove front matter for embed

Improve accessibility of viewport meta

468ee2d

Modify Chinese doc link (#1151)

0bbc02c

fix Edit Document

2cf6fd8

Merge pull request #1146 from vagra/bugfix

b2dd708

Fix #1136 and #1127

Fix typo on externalLinkRel

d5a7507

Also, add a link explaining why that can be a security issue.

Merge pull request #1156 from dungahk/patch-1

79928de

Fix typo on `externalLinkRel`

Merge pull request #1149 from chicgeek/feature/viewport-meta-accessib…

fd5ed35

…ility Improve accessibility of viewport meta by allowing page zoom (related to #945)

Merge pull request #1148 from sytone/develop

22030f4

Updated embed to strip YAML front matter fixes #1129

Merge pull request #1152 from sy-records/fix-edit-on-github

eb1a3ce

fix Edit Document

Create sidebar.js

7d38a32

Delete sidebar.js

6ac71f9

Create sidebar.js

f9d0c72

Delete sidebar.js

62d0986

Update component.js

f2ff01d

trusktr and others added 2 commits June 8, 2020 00:45

Merge branch 'develop' into allow-config-function

72ec71f

vercel bot deployed to Production June 9, 2020 16:32 View deployment

trusktr and others added 3 commits June 9, 2020 14:22

Merge branch 'develop' into allow-config-function

0438dd6

Merge branch 'develop' into update-config

7f835b1

use a port for the tests that doesn't collide with common local serve…

64a231d

…r ports

Merge branch 'master' into develop

fa47c6f

vercel bot deployed to Production June 10, 2020 19:04 View deployment

trusktr added 3 commits June 10, 2020 12:04

Merge branch 'develop' into allow-config-function

abaf6f3

Merge branch 'develop' into update-config

d9d3251

Merge pull request #1108 from jamesgeorge007/update-config

a1ddb3c

chore: remove redundant instruction from lint-staged config

vercel bot deployed to Production June 10, 2020 19:14 View deployment

trusktr and others added 3 commits June 12, 2020 21:37

Merge branch 'develop' into allow-config-function

8f3f263

* develop: chore: update auto format config

Update build/css.js

146e4c4

Co-authored-by: James George <jamesgeorge998001@gmail.com>

Merge pull request #1189 from docsifyjs/allow-config-function

da9af18

Allow configs to be functions

vercel bot deployed to Production June 13, 2020 05:23 View deployment

fix: cover overlapping sidebar by removing z-index

0bf03f5

* Fix cover overlapping sidebar * Fix transition of cover page * Revmove transition property from .cover * Remove z-index attribute from _coverpage.styl

vercel bot deployed to Production June 15, 2020 17:13 View deployment

feat: added html sanitizer for remote rendering (#1128)

714ef29

Co-authored-by: Joe Pea <joe@trusktr.io>

vercel bot deployed to Production June 17, 2020 18:26 View deployment

anikethsaha merged commit 714ef29 into master Jun 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release]: v4.11.4 #1190

[Release]: v4.11.4 #1190

anikethsaha commented May 22, 2020 •

edited

Loading

codesandbox-ci bot commented Jun 8, 2020 •

edited

Loading

trusktr commented Jun 10, 2020

anikethsaha commented Jun 17, 2020

anikethsaha commented Jun 18, 2020

trusktr commented Jun 18, 2020

trusktr commented Jun 18, 2020

trusktr commented Jun 18, 2020

anikethsaha commented Jun 18, 2020

trusktr commented Jun 18, 2020

[Release]: v4.11.4 #1190

[Release]: v4.11.4 #1190

Conversation

anikethsaha commented May 22, 2020 • edited Loading

Do Not Merge

codesandbox-ci bot commented Jun 8, 2020 • edited Loading

trusktr commented Jun 10, 2020

anikethsaha commented Jun 17, 2020

anikethsaha commented Jun 18, 2020

trusktr commented Jun 18, 2020

trusktr commented Jun 18, 2020

trusktr commented Jun 18, 2020

anikethsaha commented Jun 18, 2020

trusktr commented Jun 18, 2020

anikethsaha commented May 22, 2020 •

edited

Loading

codesandbox-ci bot commented Jun 8, 2020 •

edited

Loading