Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update cover.md #1134

Merged
merged 1 commit into from
Apr 23, 2020
Merged

[Docs] Update cover.md #1134

merged 1 commit into from
Apr 23, 2020

Conversation

sy-records
Copy link
Member

Summary

for #1132
Support multiple covers, more than one, right?
If yes, you can also merge docsifyjs/docs-zh#18docsifyjs/docs-es#2docsifyjs/docs-ru#6docsifyjs/docs-de#1

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR and triaging the #1132

@anikethsaha anikethsaha merged commit b9c3892 into docsifyjs:master Apr 23, 2020
@anikethsaha
Copy link
Member

also, You can merge those other repos PR, I have invited you to translator team

@sy-records
Copy link
Member Author

ok.

@sy-records sy-records deleted the patch-1 branch April 23, 2020 09:48
@sy-records
Copy link
Member Author

@anikethsaha docsifyjs/docs-zh#18 no permission to write.

@anikethsaha
Copy link
Member

try again

@sy-records
Copy link
Member Author

OK, thank you.

trusktr added a commit that referenced this pull request Jun 13, 2020
* develop:
  Update build/css.js
  use a port for the tests that doesn't collide with common local server ports
  Revert "Updated docs site dark and light mode with switch and redesigned search bar using docsify-darklight-theme" (#1207)
  ci: added codesandbox build preview for PR reviews (#1193)
  Update cover.md (#1134)
  chore: update auto format config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants