fix~issues 1110 #1111
fix~issues 1110 #1111
Conversation
fix bug docsifyjs#1110
fix bug docsifyjs#1098
src/plugins/search/component.js
Outdated
| // Docsify.dom.on( | ||
| // $search, | ||
| // 'click', | ||
| // e => e.target.tagName !== 'A' && e.stopPropagation() | ||
| // ); |
There was a problem hiding this comment.
fix this bug
#1098
in most cases, the element that triggers the click event is not tag A .
At this time, stopPropagation event causing click the search results on the left, the right page cannot be located.
In your source code, the location is triggered by listening to the click event
There was a problem hiding this comment.
Oh I see. I wonder why that was there though. Why did it want to prevent clicks on non-anchor tags? EDIT: nevermind, I see @sy-records's comment.
anikethsaha
requested review from
a team,
trusktr and
Koooooo-7
and removed request for
a team
|
|
src/plugins/search/component.js
Outdated
| Docsify.dom.on( | ||
| $search, | ||
| 'click', | ||
| e => e.target.tagName !== 'A' && e.stopPropagation() | ||
| ); |
There was a problem hiding this comment.
can you comment this instead of delete. also add why this is being commented.
use block comments (/** ... */)
There was a problem hiding this comment.
He said here #1111 (comment)
There was a problem hiding this comment.
yeah, this is just for future reference. we can add a link to this PR instead of details.
There was a problem hiding this comment.
Well, I tested the mobile end and he'll affect the sidebar.
There was a problem hiding this comment.
can you share the details in a separate review so that he can take a look
src/plugins/search/component.js
Outdated
| @@ -171,11 +171,6 @@ function bindEvents() { | |||
|
|
|||
| let timeId; | |||
| // Prevent to Fold sidebar | |||
| Docsify.dom.on( | |||
There was a problem hiding this comment.
After deletion, the sidebar will be collapsed when using search on the mobile end, making search unavailable.
|
@docsifyjs/reviewers We can remove the modified component.js and use this PR to fix #1110. |
|
cc @CHU295 can you change the PR to |
|
@anikethsaha I modified it for him. |
Summary
fix #1110
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
libdirectory.